Fix CSE cluster creation when using VDC Groups #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
This was referenced May 10, 2024
adambarreiro
requested review from
lvirbalas,
Didainius and
dataclouder
as code owners
adambarreiro
changed the title
lvirbalas
approved these changes
May 13, 2024
Didainius
approved these changes
May 14, 2024
Merged
dataclouder
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to vmware/terraform-provider-vcd#1258, fixing it in PR vmware/terraform-provider-vcd#1266
The filter to retrieve the networks with the target VDC was wrong, as it was using
ownerRef.idinstead oforgVdc.id:orgVdc.idand_context==includeAccessibleso this patch mimics this logic hereownerRef.idis not a VDC anymore (urn:vcloud:vdc), but a VDC Group (urn:vcloud:vdcGroup). Hence the filter returned 0 networks with the desired VDC ID.CSE tests passed in VCD 10.5.1 with CSE 4.2.1